Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cmds): encapsulate ipfs rm logic in another function #8574

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

schomatis
Copy link
Contributor

@schomatis schomatis commented Nov 30, 2021

Simplify ipfs rm command logic by extracting it into a separate function instead of having a giant loop.

This PR is actually needed for #8447 but it's submitted separately because it's:

  • independent to be reviewed on its own
  • delicate enough to be valuable to extract it from the original PR diff
  • can catch any problems sooner rather than later

(simpler to review with a split diff, and also maybe with the whitespace option)

@schomatis

This comment has been minimized.

@schomatis schomatis force-pushed the schomatis/chore/cmds/ipfs-rm-own-fn branch from a86dd74 to 367aa90 Compare November 30, 2021 19:08
@BigLep BigLep linked an issue Jan 5, 2022 that may be closed by this pull request
@guseggert guseggert merged commit 898065e into master Feb 15, 2022
@guseggert guseggert deleted the schomatis/chore/cmds/ipfs-rm-own-fn branch February 15, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants